Remove SharedCache::getNumericStorageId to let CacheWrapper do it#4004
Merged
Conversation
The CacheWrapper will properly forward the call to the wrapped cache. Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
added
3. to review
icewind1991
previously requested changes
Mar 23, 2017
icewind1991
left a comment
icewind1991
left a comment
Member
There was a problem hiding this comment.
👎 For removing it from the shared cache
Having the tests from the rest of the commit would be nice though
| return $this->cache; | ||
| } | ||
|
|
||
| public function getNumericStorageId() { |
Member
There was a problem hiding this comment.
Removing this breaks the sharing performance improvements
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
icewind1991
approved these changes
Mar 26, 2017
Member
Author
|
Unit tests fail: |
Signed-off-by: Robin Appelman <robin@icewind.nl>
Member
|
Fixed |
Codecov Report
@@ Coverage Diff @@
## master #4004 +/- ##
===========================================
- Coverage 54.33% 54.24% -0.1%
- Complexity 21167 21282 +115
===========================================
Files 1305 1310 +5
Lines 80829 81201 +372
Branches 1282 1284 +2
===========================================
+ Hits 43920 44044 +124
- Misses 36909 37157 +248
Continue to review full report at Codecov.
|
rullzer
approved these changes
Mar 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @icewind1991 does this make sense?